Use peak_sign in quality metrics.prepare_data to find template extremum#4403
Open
ecobost wants to merge 1 commit intoSpikeInterface:mainfrom
Open
Use peak_sign in quality metrics.prepare_data to find template extremum#4403ecobost wants to merge 1 commit intoSpikeInterface:mainfrom
ecobost wants to merge 1 commit intoSpikeInterface:mainfrom
Conversation
ecobost
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComputeQualityMetrics has a peak_sign argument (similar to the one in ComputeTemplateMetrics), this PR sends it to get_template_extremum_channel in prepare_data. This affects pca_metrics (if set to "pos" or "both") as it will change how the neighborhood of each unit is defined (l.154), Default behavior, peak_sign='neg', is not changed.
Note: This was originally in #4363 but I took it out as peak_sign-related issues were gonna be taken care by #4374. As #4374 will be delayed I think it's worth having this in 0.104.0.